-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Use CC12M for LCM WDS training example #5908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
711e468
a94cf3c
8c80814
110ac7f
53abd8e
309cfe1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -1097,7 +1097,7 @@ def compute_embeddings(prompt_batch, proportion_empty_prompts, text_encoder, tok | |||||||
| for epoch in range(first_epoch, args.num_train_epochs): | ||||||||
| for step, batch in enumerate(train_dataloader): | ||||||||
| with accelerator.accumulate(unet): | ||||||||
| image, text, _, _ = batch | ||||||||
| image, text = batch | ||||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just to confirm, is this change because the SD distillation script currently has a bug where it assumes that the diffusers/examples/consistency_distillation/train_lcm_distill_sd_wds.py Lines 176 to 178 in 110ac7f
and is otherwise unrelated to CC12M support?
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like 711e468 mentions this. Feel free to close :).
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, exactly, it's actually a bug and not directly related to CC12M :) |
||||||||
|
|
||||||||
| image = image.to(accelerator.device, non_blocking=True) | ||||||||
| encoded_text = compute_embeddings_fn(text) | ||||||||
|
|
||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the hyperparameters in the examples work well with the CC12M dataset or does it potentially make sense to revisit them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure to be honest. I haven't experimented much with it, considering that CC12M is very small for current standards.
Perhaps it would be easier to include a disclaimer stating that this dataset is used for illustrative purposes and users are encouraged to bring their own.