Fix LCM Stable Diffusion distillation bug related to parsing unet_time_cond_proj_dim #5893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg845
changed the title
patil-suraj
approved these changes
Nov 27, 2023
Contributor
patil-suraj
left a comment
patil-suraj
left a comment
There was a problem hiding this comment.
Good catch, thanks for fixing !
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
…e_cond_proj_dim (huggingface#5893) * Fix bug related to parsing unet_time_cond_proj_dim. * Fix analogous bug in the SD-XL LCM distillation script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes an issue in LCM Stable Diffusion distillation script
/examples/consistency_distillation/train_lcm_distill_sd_wds.pyrelated to theunet_time_cond_proj_dimparser argument. The script should accept and handleunet_time_cond_proj_dimgracefully after this change, whether the teacher checkpoint U-Net hastime_cond_proj_dimset (e.g. a nonnullvalue) or not.Fixes #5829.
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@patrickvonplaten
@patil-suraj
@sayakpaul
@justindujardin