Skip to content

Conversation

@DN6
Copy link
Collaborator

@DN6 DN6 commented Nov 17, 2023

What does this PR do?

Add test fetcher for PRs, similar to transformers.

Some notes:

  1. LoRA related tests are omitted from the test fetcher since they have dedicated workflows. I think it would be good to always run them as well
  2. Doc Tests are not included, but will be added one this PR: [tests] Doctests #5853 is merged.

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 17, 2023

The documentation is not available anymore as the PR was closed or merged.

@DN6 DN6 changed the title [WIP ]Test fetcher Add tests fetcher Nov 20, 2023
@DN6 DN6 requested a review from patrickvonplaten November 20, 2023 08:42
@patrickvonplaten
Copy link
Contributor

Should we maybe run the test fetcher and the original tests side-by-side for a week to be sure everything works correctly?
E.g. for new we just create a new workflow, called "pr_tests_2" and merge this and then check for a week whether everything works as expected?

@DN6
Copy link
Collaborator Author

DN6 commented Nov 20, 2023

@patrickvonplaten Can do. Updating the PR.

@DN6 DN6 merged commit ebc7bed into main Nov 21, 2023
affromero pushed a commit to affromero/diffusers that referenced this pull request Nov 24, 2023
* add tests fetcher to utils

* add test fetcher

* update

* update

* remove unused dependency version check script

* update

* fix mistake

* update

* update

* update

* update

* update

* update

* update

* remove concurrency params

* update

* update

* update

* update

* update

* update

* move test fetcher to dedicated workflow
@kashif kashif deleted the test-fetcher branch December 5, 2023 08:59
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
* add tests fetcher to utils

* add test fetcher

* update

* update

* remove unused dependency version check script

* update

* fix mistake

* update

* update

* update

* update

* update

* update

* update

* remove concurrency params

* update

* update

* update

* update

* update

* update

* move test fetcher to dedicated workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants