Skip to content

Conversation

@Vaibhavs10
Copy link
Contributor

Note: This is still WIP

So far I've added all the text and model utils to two separate files in the GradTTS pipeline folder.
I've also added the LinearAttention function in the attention.py file.

I am confused about adding GradTTS-specific Resnet blocks to resnet.py or directly using the ResNet2D block.

Next, I'll focus on adding the model and then the pipeline, any suggestions/ feedback is welcome.

cc: @patil-suraj & @patrickvonplaten

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@Vaibhavs10 Vaibhavs10 mentioned this pull request Sep 19, 2022
2 tasks
@patrickvonplaten
Copy link
Contributor

Hey @Vaibhavs10 ,

Do you need a review here?

@Vaibhavs10
Copy link
Contributor Author

Hi @patrickvonplaten - I am struggling a bit about splitting the Resnet blocks into a diffusers friendly format. So any quick pointers on that would be pretty helpful. after that, can we do a full review?

@patrickvonplaten
Copy link
Contributor

Hey @Vaibhavs10 :-)

Yes I think grad-tts had some weird unet/resnet blocks. Could you for now just add something that works from where we can start iterating? Essentially try to build a very hacky block in unet_block and a completely new ResnetBlock (I think we should actually create a new resnet block here)

Once that's in the PR, I'm more than happy to help :-)

@github-actions github-actions bot added the stale Issues that haven't received updates label Oct 24, 2022
@huggingface huggingface deleted a comment from github-actions bot Oct 26, 2022
@patrickvonplaten patrickvonplaten self-assigned this Oct 26, 2022
@patrickvonplaten patrickvonplaten removed the stale Issues that haven't received updates label Oct 26, 2022
@Vaibhavs10
Copy link
Contributor Author

Hey hey Patrick & team - sorry for the delay on this. Got pulled in different directions with work stuff.
This is next on my priority list and will have some updates on this in the next couple days!

@patrickvonplaten
Copy link
Contributor

Cool!

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Nov 29, 2022
@osanseviero osanseviero removed the stale Issues that haven't received updates label Nov 29, 2022
@github-actions github-actions bot closed this Dec 8, 2022
PhaneeshB pushed a commit to nod-ai/diffusers that referenced this pull request Mar 1, 2023
To enable AMD gpus on macOS, we need this detection to let the compiler know that we would be needing moltenVK to use this GPU.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants