Skip to content

Flax: ignore dtype for configuration #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pcuenca merged 1 commit into from
Sep 19, 2022
Merged

Flax: ignore dtype for configuration #565

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/diffusers/modeling_flax_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ class FlaxModelMixin:
"""
config_name = CONFIG_NAME
_automatically_saved_args = ["_diffusers_version", "_class_name", "_name_or_path"]
_flax_internal_args = ["name", "parent"]
_flax_internal_args = ["name", "parent", "dtype"]
Copy link
Contributor

@mishig25 mishig25 Sep 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you receive a warning while initializing?

Copy link
Member Author

@pcuenca pcuenca Sep 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you receive a warning while initializing?

Not about dtype. In the case of the VAE, for example, I did the following tests:

  • Loaded from the current configuration in fusing. Then I got this warning:
The config attributes {'architectures': ['encoderKL'], 'double_z': True, 'transformers_version': '4.21.0.dev0'} were passed to FlaxAutoencoderKL, but are not expected and will be ignored. Please verify your config.json configuration file.
  • Saved the configuration.
  • Saved the pretrained weights.
  • Loaded from the saved pretrained weights. No warning was emitted here.


@classmethod
def _from_config(cls, config, **kwargs):
Expand Down