Fix _upsample_2d
#535
Merged
Fix _upsample_2d
#535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
commented
Sep 16, 2022
| # Transpose weights. | ||
| weight = torch.reshape(weight, (num_groups, -1, inC, convH, convW)) | ||
| weight = weight[..., ::-1, ::-1].permute(0, 2, 1, 3, 4) | ||
| weight = torch.flip(weight, dims=[3, 4]).permute(0, 2, 1, 3, 4) |
Contributor
Author
There was a problem hiding this comment.
Without the fix, we got
ValueError: step must be greater than zeroThe syntax ::-1 is for TF tensors, not for torch tensors.
|
The documentation is not available anymore as the PR was closed or merged. |
ydshieh
commented
Sep 16, 2022
|
|
||
| stride = (factor, factor) | ||
| # Determine data dimensions. | ||
| stride = [1, 1, factor, factor] |
Contributor
Author
There was a problem hiding this comment.
F.conv_transpose2d should have a single int or a tuple of 2 integers for stride, not 4 integers.
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* Fix _upsample_2d Co-authored-by: ydshieh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
FirUpsample2D._upsample_2dis not working, it copies the syntax from TensorFlow 😆FirUpsample2D is never used with
use_conv=True, that's why we don't catch it.