Skip to content

fix guidance_rescale docstring #5063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

codinggosu
Copy link

What does this PR do?

Fixes #4864

Before submitting

Who can review?

tagging: @stevhliu for the review

@codinggosu
Copy link
Author

One question:

in StableDiffusionGLIGENPipeline the parameters to __call__ do not contain guidance_rescale, yet the docstring has string containing guidance_rescale.

Should I just remove the line regarding guidance_rescale altogether?

Currently, in this PR, I have just replaced the wrong default value for the correct one (0.7 -> 0.0)
If the reviewers think that it would be better to just remove this line for StableDiffusionGLIGENPipeline, please tell me

@patrickvonplaten
Copy link
Contributor

Thanks a lot!

@patrickvonplaten patrickvonplaten merged commit b089102 into huggingface:main Sep 18, 2023
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix guidance_rescale docstring to reflect true default value
2 participants