-
Notifications
You must be signed in to change notification settings - Fork 6.6k
[LoRA] relax lora loading logic #4610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b9a0e23
relax lora loading logic.
sayakpaul 1e4efbe
cater to the other cases too.
sayakpaul e6b4f7c
fix: variable name
sayakpaul 77fb6de
bring the chaos down.
sayakpaul 787b2c2
check
sayakpaul 45a5f73
deal with checkpointed files.
sayakpaul c688689
Apply suggestions from code review
sayakpaul 77d6571
Merge branch 'main' into feat/relax-lora-loading
sayakpaul 5253e72
style
sayakpaul 2a52cfd
Merge branch 'main' into feat/relax-lora-loading
sayakpaul File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT if this is a warning not a
raise, and we pick the first one? Not a strong opinion tho.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to raise an error than leaving it silent IMO. This promotes a sense to structuring the Hub repos too IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair. I thought about doing just a warning and still trying the best guess, like "we picked this, if you meant another one, improve your repo"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example use-case where this is useful: https://huggingface.co/Linaqruf/pastel-anime-xl-lora/tree/main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. But I think we need to meet at a common point and I would prefer the current design to promote what I said in the earlier comment.