Skip to content

Fix the Kandinsky docstring examples #3695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2023
Merged

Fix the Kandinsky docstring examples #3695

merged 1 commit into from
Jun 6, 2023

Conversation

freespirit
Copy link
Contributor

@freespirit freespirit commented Jun 6, 2023 •
edited
Loading

  • use the correct Prior hub model id
  • use the new names in KandinskyPriorPipelineOutput

closes #3693

@freespirit
Fix the Kandinsky docstring examples
ebd96bf 
 - use the correct Prior hub model id
 - use the new names in KandinskyPriorPipelineOutput
@freespirit freespirit mentioned this pull request Jun 6, 2023
Closed
@freespirit
Copy link
Contributor Author

I also noticed another potential discrepancy in the examples:

image_emb, zero_image_emb = pipe_prior(prompt, return_dict=False)

Maybe zero_image_emb should be renamed to negative_image_embeds here as well but in this case it's a matter of style and the example is still working. So I decided to leave It out of the PR and only fix the broken ones.

@freespirit freespirit mentioned this pull request Jun 6, 2023
Closed
@patrickvonplaten
Copy link
Contributor

Thank you!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 6, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@patrickvonplaten patrickvonplaten merged commit 10f4ecd into huggingface:main Jun 6, 2023
@freespirit freespirit deleted the kandinsky_docstrings_3693 branch June 6, 2023 21:35
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
@freespirit
Fix the Kandinsky docstring examples (huggingface#3695)
c57ac25 
- use the correct Prior hub model id
 - use the new names in KandinskyPriorPipelineOutput
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
@freespirit
Fix the Kandinsky docstring examples (huggingface#3695)
c2fac75 
- use the correct Prior hub model id
 - use the new names in KandinskyPriorPipelineOutput
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues in the docstrings for Kandinsky pipeline(s)
3 participants
@freespirit @patrickvonplaten @HuggingFaceDocBuilderDev