Skip to content

move activation dispatches into helper function #3656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2023
Merged

move activation dispatches into helper function #3656

merged 2 commits into from
Jun 5, 2023

Conversation

williamberman
Copy link
Contributor

@williamberman williamberman commented Jun 2, 2023 •
edited
Loading

re: #3302

williamberman
williamberman commented Jun 2, 2023
View reviewed changes
src/diffusers/models/resnet.py
Comment on lines -649 to -652
class Mish(torch.nn.Module):
def forward(self, hidden_states):
return hidden_states * torch.tanh(torch.nn.functional.softplus(hidden_states))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 2, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@williamberman williamberman mentioned this pull request Jun 2, 2023
Closed
hypnopump
hypnopump approved these changes Jun 3, 2023
View reviewed changes
Copy link

@hypnopump hypnopump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

sayakpaul
sayakpaul approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short and clean refactor! Thanks.

patrickvonplaten
patrickvonplaten approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great clean-up! This will help a lot :-)

Could you add some quick tests as well?

@williamberman williamberman force-pushed the activations_refactor branch from 2169bc4 to be9d632 Compare June 5, 2023 19:21
@williamberman
Copy link
Contributor Author

Great clean-up! This will help a lot :-)

Could you add some quick tests as well?

done!

@williamberman williamberman merged commit 41ae670 into huggingface:main Jun 5, 2023
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
@williamberman
move activation dispatches into helper function (huggingface#3656)
857e7aa 
* move activation dispatches into helper function

* tests
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
@williamberman
move activation dispatches into helper function (huggingface#3656)
a2566ff 
* move activation dispatches into helper function

* tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcuenca pcuenca pcuenca approved these changes

@hypnopump hypnopump hypnopump approved these changes

@sayakpaul sayakpaul sayakpaul approved these changes

@patrickvonplaten patrickvonplaten patrickvonplaten approved these changes

@yiyixuxu yiyixuxu Awaiting requested review from yiyixuxu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@williamberman @HuggingFaceDocBuilderDev @pcuenca @hypnopump @sayakpaul @patrickvonplaten