package version on main should have .dev0 suffix
#354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package `version` on main should have `.dev0` suffix, which is the convention followed in transformers [here](https://github.com/huggingface/transformers/blob/main/setup.py#L403) which will also make the docs built into `main` folder in [doc-build diffusers](https://github.com/huggingface/doc-build/tree/main/diffusers)
mishig25
requested review from
anton-l,
natolambert,
patil-suraj and
patrickvonplaten
|
The documentation is not available anymore as the PR was closed or merged. |
setup.py
Outdated
| setup( | ||
| name="diffusers", | ||
| version="0.2.4", | ||
| version="0.2.4.dev0", # expected format is one of x.y.z.dev0, or x.y.z.rc1 or x.y.z (no to dashes, yes to dots) |
Contributor
There was a problem hiding this comment.
Suggested change
| version="0.2.4.dev0", # expected format is one of x.y.z.dev0, or x.y.z.rc1 or x.y.z (no to dashes, yes to dots) | |
| version="0.3.0.dev0", # expected format is one of x.y.z.dev0, or x.y.z.rc1 or x.y.z (no to dashes, yes to dots) |
-> Let's do Transformers style here then as well
Contributor
There was a problem hiding this comment.
Contributor
|
@mishig25 - could you also update the version here: diffusers/src/diffusers/__init__.py Line 4 in 55d6453 0.3.0.dev0?
|
patrickvonplaten
approved these changes
Sep 5, 2022
natolambert
pushed a commit
that referenced
this pull request
Sep 7, 2022
* package `version` on main should have `.dev0` suffix package `version` on main should have `.dev0` suffix, which is the convention followed in transformers [here](https://github.com/huggingface/transformers/blob/main/setup.py#L403) which will also make the docs built into `main` folder in [doc-build diffusers](https://github.com/huggingface/doc-build/tree/main/diffusers) * dev version should be incremented * Update version in `__init__.py`
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* package `version` on main should have `.dev0` suffix package `version` on main should have `.dev0` suffix, which is the convention followed in transformers [here](https://github.com/huggingface/transformers/blob/main/setup.py#L403) which will also make the docs built into `main` folder in [doc-build diffusers](https://github.com/huggingface/doc-build/tree/main/diffusers) * dev version should be incremented * Update version in `__init__.py`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package
versionon main should have.dev0suffix, which is the convention followed in transformers hereCurrently, there are no docs for the
mainversion of diffusers because of this convention. This PR should fix the issue