-
Notifications
You must be signed in to change notification settings - Fork 6.1k
[LoRA] Enabling limited LoRA support for text encoder #2882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a009f1d
improve stable unclip doc.
sayakpaul ecf008f
Merge branch 'main' of https://github.com/huggingface/diffusers
sayakpaul 01b4d70
Merge branch 'main' of https://github.com/huggingface/diffusers
sayakpaul c2758e5
initial commits.
sayakpaul 75c4601
add: utilities to support text encoder + LoRA.
sayakpaul b500174
add: tests.
sayakpaul 6fcbb5a
add: entry to the docs.
sayakpaul 3b65ac1
fix: tests.
sayakpaul File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove the
__init__
from the Mixin? I think we could call_initialize_lora_layers()
inload_attn_procs
no?I'm not a fan of Mixins having inits because this means they can't be "plugged" into the StableDiffusionPipeline class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1,
mixins
should ideally not have__init__
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't envision this Mixin to be used with a
DiffusionPipeline
class._initialize_lora_layers()
initializes the LoRA parameters, and having it insideload_attn_procs()
is not a good choice IMO since syntactically both of them are doing different things.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: I'm here thinking more about inference of text encoder loras then training
I think we should have a function called:
load_lora()
or:
load_lora_weights(...)
That can be called from
StableDiffusionPipeline(...)
I don't think we should wrap the text encoder:
=> this breaks things for inference
text_encoder_lora_wrapper
cannot be passed to the StableDiffusionPipeline because it doesn't have a forward method, it cannot be saved etc...