add: better warning messages when handling multiple conditionings. #2804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
|
@sayakpaul Thanks for this patch! Looks good to me! |
|
Ok for me as well! |
|
I do think we can in the future support multi-batch multi-control net input. In this case, I don't think we have to pass a list of a list of image but just a list of images that we then divide further below. E.g. instead of passing: for 2 controlnets, I would allow to pass: and then split inside. |
patrickvonplaten
approved these changes
Mar 27, 2023
|
@patrickvonplaten I like that idea. Created #2855 to keep track. |
w4ffl35
pushed a commit
to w4ffl35/diffusers
that referenced
this pull request
Apr 14, 2023
…uggingface#2804) * add: better warning messages when handling multiple conditioning. * fix: handling of controlnet_conditioning_scale
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
…uggingface#2804) * add: better warning messages when handling multiple conditioning. * fix: handling of controlnet_conditioning_scale
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
…uggingface#2804) * add: better warning messages when handling multiple conditioning. * fix: handling of controlnet_conditioning_scale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion: #2704
I would prefer to not support multiple batches when multiple conditionings are passed, preferably to keep the API design simple. This is what I have tried doing in the PR.
@takuma104 could you also take a look?