Skip to content

[docs] add the Stable diffusion with Jax/Flax Guide into the docs #2487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 31, 2023

Conversation

yiyixuxu
Copy link
Collaborator

No description provided.

@yiyixuxu yiyixuxu changed the title [doc] add the Stable diffusion with Jax/Flax Guide into the docs [docs] add the Stable diffusion with Jax/Flax Guide into the docs Feb 24, 2023
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Feb 24, 2023

The documentation is not available anymore as the PR was closed or merged.

@stevhliu
Copy link
Member

stevhliu commented Mar 2, 2023

Maybe we can also move the JAX/Flax section on the GitHub README to this doc, and also add the Flax pipelines to the API docs? I couldn't find any existing examples of using the FlaxStableDiffusionPipeline, FlaxStableDiffusionImg2ImgPipeline, and FlaxStableDiffusionInpaintPipeline in the docs :)

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, @yiyixuxu could you test this once to make sure everything works with current diffusers version (0.14.0) ?

@patrickvonplaten
Copy link
Contributor

And yes we should definitely add FlaxStableDiffusionPipeline etc... to the docs as well

@yiyixuxu
Copy link
Collaborator Author

yiyixuxu commented Mar 6, 2023

@patrickvonplaten I think flax stopped working on colab again 😭😭😭
google/flax#2861

@yiyixuxu
Copy link
Collaborator Author

yiyixuxu commented Mar 6, 2023

@stevhliu
I will add the Flax pipelines to API - do you think we should add it to the same page as its pytorch counterpart?
e.g. we can add FlaxStableDiffusionPipeline to this page

It seems that Flax/Jax section in README only contains the most basic use examples - I think these examples needed to be added to docstrings so they would show up on the flax pipelines' API page. What do you think?

@stevhliu
Copy link
Member

stevhliu commented Mar 6, 2023

Big yes to both of your questions @yiyixuxu 👍. Having all the StableDiffusion pipeline information on a single page with code examples for how to use the API will be amazing!

@krahnikblis
Copy link

@patrickvonplaten I think flax stopped working on colab again 😭😭😭 google/flax#2861

hey i've been wrestling with this specific issue (Flax HF pipelines on Colab) for weeks and finally got past the version compatibility issue, at least with Flax; check the workaround in the issue post here - might be useful but i'm not sure how the automated setup of Diffusers/Transformers dependencies would handle the recursive dependency of Flax<>Orbax; i.e. if my workaround method could be used here, or required to be done before installing HF libs...

@patrickvonplaten
Copy link
Contributor

Gentle ping here @yiyixuxu

@yiyixuxu yiyixuxu merged commit 51d970d into huggingface:main Mar 31, 2023
@yiyixuxu yiyixuxu deleted the add-notebook-doc-jax branch March 31, 2023 02:22
w4ffl35 pushed a commit to w4ffl35/diffusers that referenced this pull request Apr 14, 2023
…ggingface#2487)

* add stable diffusion jax guide


---------
Co-authored-by: Patrick von Platen <[email protected]>
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
…ggingface#2487)

* add stable diffusion jax guide


---------
Co-authored-by: Patrick von Platen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants