Skip to content

[Latent Upscaling] Remove unused noise #2298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

patrickvonplaten
Copy link
Contributor

@patrickvonplaten patrickvonplaten commented Feb 9, 2023

Inputs is never used

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Feb 9, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there was a comment in the original code that said adding noise could theoretically work better, but they found that 0 was actually best. So yes, it's better to keep things simple imo :)

@patrickvonplaten patrickvonplaten merged commit bc0cee9 into main Feb 13, 2023
@patrickvonplaten patrickvonplaten deleted the remove_unused_noise_level_input branch February 13, 2023 17:07
mengfei25 pushed a commit to mengfei25/diffusers that referenced this pull request Mar 27, 2023
@chillpixelfun
Copy link
Contributor

@patrickvonplaten @pcuenca Will you add this back please? 🙏 Noise is definitely a used feature. It's so important it has a spot on the home screen of AUTOMATIC1111.
Screen Shot 2023-04-08 at 12 21 35 AM

@patrickvonplaten
Copy link
Contributor Author

Hey @chillpixelgames,

I think it was simply not used at the moment for latent upscaling so we didn't remove any functionality here. Also @yiyixuxu here for the latent upscaling model

yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants