Add leave=False for tqdm steps to allow nesting #226
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Good to merge for me here! @patil-suraj @anton-l what do you think? |
Merged
Contributor
|
@darthdeus, I think PR #242 should allow for this functionality by providing a kwargs input. Closing here (hope that's ok) |
PhaneeshB
pushed a commit
to nod-ai/diffusers
that referenced
this pull request
Mar 1, 2023
…ngface#226) * Update nightly.yml to fix wheel building issues. * Update setup_venv.sh to only install torch+cu116 if IMPORTER=1 is set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a relatively small change that allows nesting of the
pipe(...)call inside anothertqdmloop. Without this the output looks like thiswhere each intermediate run produces a progress bar. This pollutes the output the more nested loops of inference are run. With the change the inner-most progress bar disappears after each run, allowing arbitrary number of calls to
pipe(...), with just the top bar being shown in the endI'm not sure if this should be enabled by default, maybe it should be a flag as part of the kwargs?