do not automatically enable xformers #1640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickvonplaten
commented
Dec 9, 2022
| # 3. Feed-forward | ||
| self.norm3 = nn.LayerNorm(dim) | ||
|
|
||
| # if xformers is installed try to use memory_efficient_attention by default |
Contributor
Author
There was a problem hiding this comment.
We should not automatically enable xformers for three reasons:
-
- It's not PyTorch-like API. PyTorch doesn't by default enable all the fastest options available
-
- We allocate GPU memory before the user even does
.to("cuda")
- We allocate GPU memory before the user even does
-
- This behavior is not consistent with cases where xformers is not installed
Contributor
Author
There was a problem hiding this comment.
anton-l
approved these changes
Dec 9, 2022
Member
anton-l
left a comment
anton-l
left a comment
There was a problem hiding this comment.
Very much agree with the reasoning, thanks for the update!
|
The documentation is not available anymore as the PR was closed or merged. |
…remove_automatic_xformers
anton-l
pushed a commit
that referenced
this pull request
Dec 9, 2022
* do not automatically enable xformers * uP
tcapelle
pushed a commit
to tcapelle/diffusers
that referenced
this pull request
Dec 12, 2022
* do not automatically enable xformers * uP
sliard
pushed a commit
to sliard/diffusers
that referenced
this pull request
Dec 21, 2022
* do not automatically enable xformers * uP
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* do not automatically enable xformers * uP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.