Skip to content

Conversation

@SkyTNT
Copy link
Contributor

@SkyTNT SkyTNT commented Dec 9, 2022

Make it works on diffusers < 0.10.0

Fixes: #1604 , #1616

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Dec 9, 2022

The documentation is not available anymore as the PR was closed or merged.

@SkyTNT
Copy link
Contributor Author

SkyTNT commented Dec 9, 2022

@patrickvonplaten , Can you take a look?

@patrickvonplaten
Copy link
Contributor

Awesome!

@patrickvonplaten patrickvonplaten merged commit f242eba into huggingface:main Dec 9, 2022
@adhikjoshi
Copy link

adhikjoshi commented Dec 9, 2022

@patrickvonplaten as diffusers become more stable and widely used, we need to make sure all updates are compatible at least with few past versions, to avoid any breaking changes and will avoid lots of issues which are emerging a lot due to incompatible updates.

Can we have some checks for this for all merged requests?

@kovtcharov
Copy link

Thank you for fixing this so quickly, much appreciated!

tcapelle pushed a commit to tcapelle/diffusers that referenced this pull request Dec 12, 2022
@patrickvonplaten
Copy link
Contributor

ome more stable and widely used, we need to make sure all updates are compatible at least with few past versions, to avoi

I agree, the current mechanism of how we always fetch the community pipelines from "main" is suboptimal. I'll open a PR to instead use the current version of diffusers to fetch the community pipelines and then we could also maybe add a test folder where community contributors can add tests for their pipelines ? Wdyt @anton-l maybe we can run highly used community pipelines as nightly tests?

@anton-l
Copy link
Member

anton-l commented Dec 13, 2022

run highly used community pipelines as nightly tests

Thought about that too, added a reminder in #1679

@patrickvonplaten
Copy link
Contributor

Fixing here: #1680

sliard pushed a commit to sliard/diffusers that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lpw_stable_diffusion.py broken when using diffusers==0.9.0

6 participants