-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Propose to update & upgrade SkyReels-V2 #12167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Wraps the visual demonstration section in a Markdown code block. This change corrects the rendering of ASCII diagrams and examples, improving the overall readability of the document.
Improves the readability of the `step_matrix` examples by replacing long sequences of repeated numbers with a more compact `value×count` notation. This change makes the underlying data patterns in the examples easier to understand at a glance.
…ne and sine frequencies
…rt and remove outdated notes
44d84e4
to
5c6ce3c
Compare
…ine.to("cuda") for GPU allocation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving the docs!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, the docs LGTM!
Let's wait for @a-r-r-o-w to chime in on the other changes before we merge :)
Alright, thanks for your review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice @tolgacangoz! Thanks for propagating the attention backend changes to SkyReels
Removed comments about acceleration helpers and Flash Attention installation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Just one last change similar to the following:
diffusers/src/diffusers/models/transformers/transformer_wan.py
Lines 159 to 166 in 0d1c5b0
class WanAttnProcessor2_0: | |
def __new__(cls, *args, **kwargs): | |
deprecation_message = ( | |
"The WanAttnProcessor2_0 class is deprecated and will be removed in a future version. " | |
"Please use WanAttnProcessor instead. " | |
) | |
deprecate("WanAttnProcessor2_0", "1.0.0", deprecation_message, standard_warn=False) | |
return WanAttnProcessor(*args, **kwargs) |
Could you add a deprecation message by creating a dummy SkyReelsV2AttnProcessor2_0
class for BC?
Right, I missed realizing the previous code was in the released version. |
Thanks for the reviews and merging! |
@sayakpaul , looks like it was merged but feel free to leave any comments and we can iterate on it further! |
"_native_cudnn"
for self-attentions and"flash_varlen"
or"_flash_varlen_3"
for cross-attentions.pipeline.transformer.compile_repeated_blocks(fullgraph=True)
and looking forward to be merged torch.compile compatibility with varlen APIs #11970.main
: ~14 min.main.mp4
Wan.s_RoPE.mp4
compile_repeated_blocks(fullgraph=True)
: ~12 min.compile_repeated_blocks(fullgraph=True)
+"_native_cudnn"
forattn1
and"flash"
forattn2
, FA=2.8.3: ~8 min.Wan.s_RoPE+regional.mp4
Wan.s_RoPE+regional+FA.mp4
Reproducer
Environment
@a-r-r-o-w @yiyixuxu @stevhliu