-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Qwen Image Edit Support #12164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qwen Image Edit Support #12164
Conversation
add qwen-image-edit support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @naykun!
|
||
# 是否使用 scale rope | ||
# DO NOT USING REGISTER BUFFER HERE, IT WILL CAUSE COMPLEX NUMBERS LOSE ITS IMAGINARY PART |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @sayakpaul for review of rope changes
@naykun We refactored the RoPE logic in #12061 to make it compatible with torch.compile
. Would you be able to add the relevant changes for QwenEdit with the current implementation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the latest commit, I have refactored the code as described in #12061.
Please kindly review and let me know if it looks good. Local testing confirms that it correctly generates images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aweesome! thank you!
- compatible with torch.compile in new rope setting - fix init import - add prompt truncation in img2img and inpaint pipe - remove unused logic and comment - add copy statement - guard logic for rope video shape tuple
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
- make fix-copies - update doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Will merge now!
(Not sure if the RoPE refactor works completely - I think we need to test for recompilation, but that can be updated and reviewed in a follow-up PR, cc @a-r-r-o-w)
hi @naykun, where do you find |
Hi @TuanNT-ZenAI , while Qwen-Image-Edit was trained on multiple resolutions, we find that the resolution settings from FluxKontext offer a reliable and consistent baseline for inference. These defaults may be refined in future updates. |
This pull request introduces support for Qwen Image Edit.
For additional information, please visit the Qwen-Image repository .
If you find our work beneficial, we kindly encourage you to star the repository, which will help accelerate the release of the checkpoint.
cc @yiyixuxu @a-r-r-o-w