Fixed iOS build breaking #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CGRectMake in line 14 is not a proper return type. It is a function. hence it is removed and the menu containing the list of applications to open the file with is created manually in line 37.
|
I think this should be added too, otherwise the compiling fails... |
|
In our builds it's compiling without any problems, which makes sense because of the plus it should already use the latest version of react-native for compilation. |
|
I actually think that 0.20.+ means you get only 0.20 pathes (eg. 0.20.1). You dont get 0.47 which is the version where createJSModules was removed... Weird that it compiles in your env :-/ |
|
Please merge this. Same issue with react-native "^0.55.4" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
FileOpenerPackage.javato no longer override the deprecatedcreateJSModulesmethod, fixed broken React imports inRNFileOpener.hand fixedCGRectMakereturn type.