Fix changeOrigin #231
Closed
Fix changeOrigin #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 would really like to see this pulled in |
Closed
|
+1 I'm writing a simple Node+CouchDB backend for a client-side single-page webapp (a learning game). One of the backend's jobs is to reverse-proxy two legacy services we provide via Apache name-based virtual hosts. Without @coderarity's patch, the name based virtual hosts will not respond. Setting X-Forwarded-For is not sufficient. Thanks... |
|
+1 |
2 similar comments
|
+1 |
|
👍 |
|
#247 also got 3 or 4 +1's before I closed it in favour of this one. |
|
I would also like to see this pulled in. |
|
Cherry-picked. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was reverted a long time ago. I don't know why, because nobody explained it. I added it back, as it seems necessary looking at #150. There seemed to be some discussion saying it was unnecessary, but note that was before it used the changeOrigin option. This shouldn't change anything for anyone not using changeOrigin. If there's a reason to not use it, please document it this time. Thanks!