Messages increment #593
Merged
Messages increment #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ispatchTable reflects such. Some fleshed in report formatters are included with cases for several of Tidy's reports, but nothing is yet enabled. All reporting is status quo, and this is just a bunch of dead code at this point.
…d the badAccess flag to the point of detection.
…stem. All tests passing.
… messaging system. Migrated old reportNotice() to report().
…ved with braces to not pollute stack for other cases.
…e items. Note that there are several regressions in the accessibility test suit that are not related to output messages. These are a result of previous work, and these results should be updated in the test suite when this item is merged.
…ed elsewhere in code now.
…ed elsewhere in code now, here, too.
At this point:
- MSVC on Windows 10 compiles without warnings or errors.
- GCC on Ubuntu 16.04 compiles without warnings or errors.
- Test cases in `testbase` are clean on all of:
- macOS
- Windows 10
- Ubunutu
Updated language_fr.h reflect the re-sorted strings.
Simplified the update counting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the internal messaging system to simplify the handling of report output. This is an internal API-only change and does not affect LibTidy users or change output in any way (verified by regression testing).
This implements the "good ideas" from #561, without touching the other things subject to further discussion.