feat: Add "Sync" version of Graphviz #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GordonSmith
force-pushed
the
GRAPHVIZ_SYNC
branch
from
84b405f to
ca171b1
Compare
|
@magjac please review |
GordonSmith
force-pushed
the
GRAPHVIZ_SYNC
branch
3 times, most recently
from
daba7c6 to
e646cbb
Compare
Note: The initializer will still need to be asynchronous (to load wasm). Fixes hpcc-systems#8 Signed-off-by: Gordon Smith <[email protected]>
GordonSmith
force-pushed
the
GRAPHVIZ_SYNC
branch
from
e646cbb to
f80a626
Compare
|
Works like a charm 🍾. Thank you so much 💪. |
|
I think the API Reference in the README could be a bit more detailed on that the asynchronous functions returns promises and what the fulfillment values of those promises are (strings). Also what the return values of the synchronous functions are (strings). |
magjac
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: The initializer will still need to be asynchronous (to load wasm).
Fixes #8
Signed-off-by: Gordon Smith [email protected]