Error handling using GraphvizSync() layout

[magjac]

I'm not at all sure that this is a bug in hpcc-js/wasm, but I have indications that the error handling when using GraphvizSync() does not work. I'm getting an error saying "full function or function signature mismatch" instead of the expected "syntax error in line 1 near 'bad'".

I haven't yet had time to boil this down to a minimal test case, so for now this is mainly a question if you have tested this. Error handling using the asynchronous Graphviz() seems to work as expected.

More details can be found at https://github.com/magjac/d3-graphviz/actions/runs/3372738896/jobs/5596518645

If this seems to work for you I will try to carve out some time to create a minimal test case.

[GordonSmith]

@magjac - thanks, FWIW this was caused by a change in the latest c++ layer, where syntax error exceptions are no longer caught within the c++ code (and I had fixed it in the async variant).

[magjac]

Excellent! Thanks for the rapid fix. A new release would be immensely appreciated.

[GordonSmith]

@magjac that release is out now, with added Zstd compression wasm and base91 wasm...

[magjac]

Thank you so much. I however get a lot of failures in my tests with that version:

  ✔ data() returns the data saved by dot().
wasm streaming compile failed: TypeError [ERR_INVALID_ARG_TYPE]: The "source" argument must be an instance of Response or an Promise resolving to Response. Received an instance of Object
falling back to ArrayBuffer instantiation
Aborted(both async and sync fetching of the wasm failed)
failed to asynchronously prepare wasm: RuntimeError: Aborted(both async and sync fetching of the wasm failed). Build with -sASSERTIONS for more info.
Aborted(RuntimeError: Aborted(both async and sync fetching of the wasm failed). Build with -sASSERTIONS for more info.)
evalmachine.<anonymous>:936
  1) .destroy() deletes the Graphviz instance from the container element (shared worker version)
    var Module=typeof cpp!="undefined"?cpp:{};var readyPromiseResolve,readyPromiseReject;Module["ready"]=new Promise(function(resolve,reject)
...

I haven't had time to look into them yet so it might still be something I'm doing wrong, but I thought I might let you know directly if you recognize something.

It seems that it is only the tests that have problem. The build seems to work fine.

Full log:
https://github.com/magjac/d3-graphviz/actions/runs/3381171576/jobs/5614782415

[GordonSmith]

Is your test/@hpcc-js/wasm/dist/wrapper.js used in a NodeJS environment? If so it should be wrapping node_modules/@hpcc-js/wasm/dist/index.node.js (cjs) or node_modules/@hpcc-js/wasm/dist/index.es6.mjs (esm)

[GordonSmith]

dist/index.js -> browser UMD
dist/index.es6.js -> browser ESM
dist/index.node.js -> NodeJS CJS
dist/index.node.es6.mjs -> NodeJS ESM

I think your errors are from NodeJS loading a browser bundle...
Or it may be simply not locating the wasm file for reading (you may need to call wasmFolder)

[magjac]

Some feedback:

1. The error handling fix now works. Thanks a lot.
2. The wrapper is used inside a web worker implemented by https://github.com/avoidwork/tiny-worker. I don't know what kind of environment that is, but I just read someting about enabling ES6 in the docs. Will try another day.
3. node_modules/@hpcc-js/wasm/dist/index.es6.mjs does not exist. I tried with node_modules/@hpcc-js/wasm/dist/index.node.es6.mjs and node_modules/@hpcc-js/wasm/dist/index.es6.js, but none of them even loads in the web worker.
4. I then tried with node_modules/@hpcc-js/wasm/dist/index.node.js and it loads, but fails on Object.defineProperty(exports, '__esModule', { value: true }); since exports is undefined. I worked around that, by creating it before importing the script and then it came further, but failed the call: const __filename$1 = url.fileURLToPath(importUrl);. Then I decided I was too far into the rabbit hole and called it a day.

I will start with a fresh brain another day. Any tips are welcome. It seems that something radical changed in version 1.19.0, but it may very well be my usage that has been wrong the whole time.