Skip to content

Conversation

@KKZ20
Copy link
Contributor

@KKZ20 KKZ20 commented Sep 27, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

Add an argument to support whether to store a master copy of weights in fp32. Test results on the Bert model are as follows:

image

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

Copy link

@RelxOff RelxOff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link
Contributor

The code coverage for the changed files is %.

Click me to view the complete report
Name                                                  Stmts   Miss  Cover
-------------------------------------------------------------------------
colossalai/booster/plugin/hybrid_parallel_plugin.py     366     41    89%
colossalai/booster/plugin/low_level_zero_plugin.py      144     11    92%
colossalai/zero/low_level/low_level_optim.py            365     32    91%
-------------------------------------------------------------------------
TOTAL                                                   875     84    90%

@KKZ20 KKZ20 merged commit a0684e7 into hpcaitech:main Oct 13, 2023
flybird11111 pushed a commit to flybird11111/ColossalAI that referenced this pull request Oct 18, 2023
…pcaitech#4816)

* [feature] support no master weights for low level zero plugin

* [feature] support no master weights for low level zero plugin, remove data copy when no master weights

* remove data copy and typecasting when no master weights

* not load weights to cpu when using no master weights

* fix grad: use fp16 grad when no master weights

* only do not update working param when no master weights

* fix: only do not update working param when no master weights

* fix: passing params in dict format in hybrid plugin

* fix: remove extra params (tp_process_group) in hybrid_parallel_plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants