Skip to content

Obj open fix #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 17, 2025
Merged

Obj open fix #279

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d91d36a
Fix seg fault for PDCobj_open on non-existent object
TheAssembler1 Jul 12, 2025
f075c9c
Committing clang-format changes
github-actions[bot] Jul 12, 2025
8db801e
Remove log from NULL check
TheAssembler1 Jul 14, 2025
b2b9366
Log message when object metadata isn't found.
TheAssembler1 Jul 15, 2025
86140ca
Merge branch 'develop' into obj_open_fix
jeanbez Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/api/pdc_client_connect.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2422,8 +2422,17 @@ PDC_Client_query_metadata_name_timestep(const char *obj_name, int time_step, pdc
hg_atomic_set32(&atomic_work_todo_g, 1);
PDC_Client_check_response(&send_context_g);
*out = lookup_args.data;
LOG_DEBUG("rank = %d, PDC_Client_query_metadata_name_timestep = %u\n", pdc_client_mpi_rank_g,
out[0]->data_server_id);

/**
* Not necessarily an error. If the obj does not exist
* then this will be NULL. Still need to return as FAIL
* otherwise calling code will expect *out to be non-NULL.
*/
if (*out == NULL) {
LOG_INFO("Object metadata does not exist\n");
PGOTO_DONE(FAIL);
}

done:
HG_Destroy(metadata_query_handle);

Expand Down
Loading