Skip to content

🎨 Enable ESLint import order rule #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 12, 2020
Merged

🎨 Enable ESLint import order rule #283

merged 12 commits into from
Oct 12, 2020

Conversation

jrolfs
Copy link
Collaborator

@jrolfs jrolfs commented Oct 11, 2020

Enable import/order with alphabetize set to asc.

@jrolfs jrolfs self-assigned this Oct 11, 2020
@github-actions github-actions bot force-pushed the feature/new-eslint-rules branch from 65f6364 to 2ec2222 Compare October 11, 2020 21:27
@codecov
Copy link

codecov bot commented Oct 11, 2020 •
edited
Loading

Codecov Report

Merging #283 into beta will increase coverage by 0.00%.
The diff coverage is 94.44%.

Impacted file tree graph

@@           Coverage Diff           @@
##             beta     #283   +/-   ##
=======================================
  Coverage   93.65%   93.66%           
=======================================
  Files          22       23    +1     
  Lines         268      284   +16     
  Branches       58       59    +1     
=======================================
+ Hits          251      266   +15     
- Misses         16       17    +1     
  Partials        1        1
Impacted Files Coverage Δ
src/config/commitlint.config.js 0.00% <0.00%> (ø)
src/config/helpers/build-eslint.js 100.00% <ø> (ø)
src/config/lintstagedrc.js 100.00% <ø> (ø)
src/api/commit.js 100.00% <100.00%> (ø)
src/config/eslintrc-react.js 100.00% <100.00%> (ø)
src/config/eslintrc.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2f35d6...90b8f36. Read the comment docs.

@jrolfs jrolfs force-pushed the feature/new-eslint-rules branch from 2ec2222 to a5b7104 Compare October 12, 2020 00:22
jrolfs added 11 commits October 12, 2020 00:23
@jrolfs
build: add commitlint scope deps-dev
648531b
@jrolfs
build: add top level directories to commitlint configuration
8c7f94c
@jrolfs
feat(api): add commit API module with commitlint scope helper
dd996e8
@jrolfs
feat(config/commitlint): add deps-dev , format , and lint as scopes (…
acefd0d 
…intended for `build()`)
@jrolfs
fix(config/commitlint): remove 'build' scope
8952227
@jrolfs
feat(api/commit): expose scopes module with some common scope lists
a76c5ee
@jrolfs
build(commit): dogfood ls helper from API
b5cda63
@jrolfs
build(commit): dogfood scopes helper from API
a2c0baf
@jrolfs
feat(api/commit): add ls.dirs scope enumeration helper
a908331
@jrolfs
refactor(config/eslint): rename ESlint 'builder'
8dbc250
@jrolfs
feat(config/eslintrc): enable import/order and sort-imports rule
be88ce0 
BREAKING CHANGE: sets `import/order` (with `alphabetize` set to `asc`) and
`sort-imports` rules to `error`
@github-actions github-actions bot force-pushed the feature/new-eslint-rules branch from a5b7104 to be88ce0 Compare October 12, 2020 00:23
@jrolfs jrolfs changed the base branch from beta to master October 12, 2020 00:27
@jrolfs jrolfs changed the base branch from master to beta October 12, 2020 00:27
@jrolfs jrolfs merged commit 8d4939b into beta Oct 12, 2020
@jrolfs jrolfs deleted the feature/new-eslint-rules branch October 12, 2020 00:32
@jrolfs
Copy link
Collaborator Author

jrolfs commented Oct 12, 2020

🎉 This PR is included in version 5.0.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jrolfs jrolfs

Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jrolfs