Skip to content

Commit 8d4939b

Browse files
authored
Merge pull request #283 from hoverinc/feature/new-eslint-rules
2 parents a2f35d6 + 90b8f36 commit 8d4939b

File tree

3 files changed

+16
-3
lines changed

3 files changed

+16
-3
lines changed

src/config/eslintrc-react.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
const {buildConfig} = require('./helpers/eslint')
1+
const {buildConfig} = require('./helpers/build-eslint')
22

33
module.exports = buildConfig({withReact: true})

src/config/eslintrc.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
const {buildConfig} = require('./helpers/eslint')
1+
const {buildConfig} = require('./helpers/build-eslint')
22

33
module.exports = buildConfig()

src/config/helpers/eslint.js renamed to src/config/helpers/build-eslint.js

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ const buildConfig = ({withReact = false} = {}) => {
4040
ifReact('plugin:react-hooks/recommended'),
4141
].filter(Boolean),
4242
rules: {
43-
'prettier/prettier': 'error',
4443
'import/prefer-default-export': 'off',
4544
'import/no-extraneous-dependencies': [
4645
'error',
@@ -55,7 +54,21 @@ const buildConfig = ({withReact = false} = {}) => {
5554
optionalDependencies: false,
5655
},
5756
],
57+
'import/order': [
58+
'error',
59+
{
60+
alphabetize: {order: 'asc'},
61+
'newlines-between': 'always',
62+
pathGroups: [
63+
{pattern: 'src/**/*', group: 'parent', position: 'before'},
64+
{pattern: 'assets/**/*', group: 'parent', position: 'before'},
65+
],
66+
pathGroupsExcludedImportTypes: ['builtin'],
67+
},
68+
],
5869
'no-void': ['error', {allowAsStatement: true}],
70+
'prettier/prettier': 'error',
71+
'sort-imports': ['error', {ignoreDeclarationSort: true}],
5972
...parserRules(false, isReact),
6073
},
6174
overrides: [

0 commit comments

Comments
 (0)