DTR-685: DASS Technical Refresh SDLT - Screen MA-overview- Manage Agent Overview - T2 #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # conf/app.routes # conf/messages.en
|
avelx
reviewed
Oct 28, 2025
test/controllers/manageAgents/StartAddAgentControllerSpec.scala
Outdated
Show resolved
Hide resolved
avelx
reviewed
Oct 28, 2025
avelx
reviewed
Oct 28, 2025
avelx
reviewed
Oct 28, 2025
avelx
reviewed
Oct 28, 2025
avelx
reviewed
Oct 28, 2025
avelx
reviewed
Oct 28, 2025
avelx
previously approved these changes
Oct 28, 2025
Contributor
avelx
left a comment
avelx
left a comment
There was a problem hiding this comment.
approved with comments;
we might need to refactor pagination code in the future
avelx
reviewed
Oct 28, 2025
avelx
reviewed
Oct 28, 2025
avelx
reviewed
Oct 28, 2025
| val host: String = configuration.get[String]("host") | ||
| val appName: String = configuration.get[String]("appName") | ||
|
|
||
| val maxNumberOfAgents: Int = configuration.get[Int]("max-number-of-agents") |
Contributor
There was a problem hiding this comment.
I am not sure what we have in the requirement, is that max number of agents in total ? or per page ?
avelx
approved these changes
Oct 28, 2025
Contributor
avelx
left a comment
avelx
left a comment
There was a problem hiding this comment.
approved: assume we would simplify pagination logic in the future/separate pagination logic from styling etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.