Skip to content

[DTR-359] Screen C3 - Email Input Regex #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[DTR-359] Screen C3 - Email Input Regex #25

wants to merge 4 commits into from

Conversation

@wg-hmrc
Copy link
Contributor

@wg-hmrc wg-hmrc commented Sep 19, 2025 •
edited
Loading

[Tasks]

  • Updated email validation messages
  • Fixed stale email autofill after CYA submission

@platops-pr-bot
Copy link

platops-pr-bot commented Sep 19, 2025

@platops-pr-bot
Copy link

platops-pr-bot commented Sep 19, 2025

yanshengzhangHMRC
yanshengzhangHMRC previously approved these changes Sep 19, 2025
View reviewed changes
Copy link
Contributor

@yanshengzhangHMRC yanshengzhangHMRC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and as confirmed by Waigwa, session data clear will be covered by DTR-189

SandipKhedekar
SandipKhedekar suggested changes Sep 19, 2025
View reviewed changes
SandipKhedekar
SandipKhedekar approved these changes Sep 22, 2025
View reviewed changes
Copy link
Contributor

@SandipKhedekar SandipKhedekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yanshengzhangHMRC yanshengzhangHMRC yanshengzhangHMRC left review comments

@jassalrichy jassalrichy Awaiting requested review from jassalrichy

+1 more reviewer

@SandipKhedekar SandipKhedekar SandipKhedekar approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wg-hmrc @platops-pr-bot @SandipKhedekar @yanshengzhangHMRC