Skip to content

Conversation

@hitesh-wagento
Copy link
Owner

Original Pull Request

magento#15902

Description

Using getCurrencySymbol() leads to a bug for currencies where there is no currency symbol - cache ends up being non-unique. Using currency code for caching is a more foolproof way.

The issue has been partially fixed in 2.2-develop branch in magento#13894 (Magento\ConfigurableProduct\Block\Product\View\Type\Configurable)
and magento#14559 (Magento\CatalogWidget\Block\Product\ProductsList).

Manual testing scenarios

  1. Test the Catalog Category View page (including configurable products)
  2. Test the Catalog Product List widget

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@hitesh-wagento hitesh-wagento merged this pull request into 2.1-develop Jun 14, 2018
@hitesh-wagento hitesh-wagento deleted the 2.1-develop-PR-port-15902 branch September 6, 2018 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants