Skip to content

Conversation

@natanasow
Copy link
Member

@natanasow natanasow commented Nov 19, 2025

Description

Bumps pino from 9.14.0 to 10.1.0.

The comma-separated logs are affected by a breaking change and require manual fixes (described here).

Related issue(s)

Fixes #4510

Testing Guide

Changes from original design (optional)

N/A

Additional work needed (optional)

N/A

Checklist

  • I've assigned an assignee to this PR and related issue(s) (if applicable)
  • I've assigned a label to this PR and related issue(s) (if applicable)
  • I've assigned a milestone to this PR and related issue(s) (if applicable)
  • I've updated documentation (code comments, README, etc. if applicable)
  • I've done sufficient testing (unit, integration, etc.)

@natanasow natanasow added this to the 0.73 milestone Nov 19, 2025
@natanasow natanasow self-assigned this Nov 19, 2025
@natanasow natanasow requested review from a team as code owners November 19, 2025 14:45
@natanasow natanasow added the enhancement New feature or request label Nov 19, 2025
@natanasow natanasow requested a review from simzzz November 19, 2025 14:45
@github-actions
Copy link

github-actions bot commented Nov 19, 2025

Test Results

 20 files  +  7  272 suites  +104   21m 46s ⏱️ + 7m 17s
791 tests +251  787 ✅ +253  4 💤 ±0  0 ❌  - 2 
807 runs  +251  803 ✅ +253  4 💤 ±0  0 ❌  - 2 

Results for commit 247d4fb. ± Comparison against base commit e1a74b9.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see updates like adding the new msg field, I assume that’s the new way to work with pino v10. But we have more logs in the codebase, right? Why were only these updated in this PR?

@natanasow
Copy link
Member Author

I see updates like adding the new msg field, I assume that’s the new way to work with pino v10. But we have more logs in the codebase, right? Why were only these updated in this PR?

Only the comma-separated logs are affected.

E.g. 👇 should not be refactored.

this.logger.trace(`Retry delay ${delay} ms on '${error?.request?.path}'`);

But 👇 should be transform to an object:

this.logger.debug(
  `Making eth_call on contract ${call.to} with gas ${gas} and call data "${call.data}" from "${call.from}" at blockBlockNumberOrTag: "${block}" using mirror-node.`,
  call.to,
  gas,
  call.data,
  call.from,
  block,
);

@natanasow natanasow requested a review from quiet-node November 19, 2025 19:13
@konstantinabl
Copy link
Contributor

Can we add description, since there are additional changes, just a small concise one is enough and fill the checklist 🙌

Copy link
Contributor

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natanasow natanasow merged commit 30fbbf6 into main Nov 21, 2025
70 of 73 checks passed
@natanasow natanasow deleted the 4531-bump-pino-version branch November 21, 2025 08:04
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main    #4632      +/-   ##
==========================================
+ Coverage   94.75%   95.46%   +0.71%     
==========================================
  Files         129      129              
  Lines       20903    20904       +1     
  Branches     1745     1782      +37     
==========================================
+ Hits        19806    19956     +150     
+ Misses       1076      928     -148     
+ Partials       21       20       -1     
Flag Coverage Δ
config-service 98.83% <ø> (ø)
relay 90.91% <36.36%> (+<0.01%) ⬆️
server 88.93% <ø> (ø)
ws-server 98.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/relay/src/lib/clients/sdkClient.ts 95.87% <100.00%> (+0.32%) ⬆️
...ices/ethService/contractService/ContractService.ts 93.94% <100.00%> (ø)
...thService/transactionService/TransactionService.ts 98.85% <100.00%> (+8.42%) ⬆️
...services/rateLimiterService/RedisRateLimitStore.ts 98.13% <100.00%> (ø)

... and 17 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants