-
Notifications
You must be signed in to change notification settings - Fork 93
build(deps): bump pino from 9.7.0 to 10.1.0 #4632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: nikolay <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see updates like adding the new msg field, I assume that’s the new way to work with pino v10. But we have more logs in the codebase, right? Why were only these updated in this PR?
Only the comma-separated logs are affected. E.g. 👇 should not be refactored. this.logger.trace(`Retry delay ${delay} ms on '${error?.request?.path}'`);But 👇 should be transform to an object: this.logger.debug(
`Making eth_call on contract ${call.to} with gas ${gas} and call data "${call.data}" from "${call.from}" at blockBlockNumberOrTag: "${block}" using mirror-node.`,
call.to,
gas,
call.data,
call.from,
block,
); |
|
Can we add description, since there are additional changes, just a small concise one is enough and fill the checklist 🙌 |
quiet-node
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4632 +/- ##
==========================================
+ Coverage 94.75% 95.46% +0.71%
==========================================
Files 129 129
Lines 20903 20904 +1
Branches 1745 1782 +37
==========================================
+ Hits 19806 19956 +150
+ Misses 1076 928 -148
+ Partials 21 20 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 17 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Description
Bumps pino from 9.14.0 to 10.1.0.
The comma-separated logs are affected by a breaking change and require manual fixes (described here).
Related issue(s)
Fixes #4510
Testing Guide
Changes from original design (optional)
N/A
Additional work needed (optional)
N/A
Checklist