pkg/devcontainer: test runner #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artmoskvin
force-pushed
the
artm/runner-test
branch
2 times, most recently
from
fbab275 to
e2455ab
Compare
aleh-null
approved these changes
Sep 4, 2024
Collaborator
aleh-null
left a comment
aleh-null
left a comment
There was a problem hiding this comment.
LGTM. Let's have a chat about ExecResult{} seems like the only reason of it is to push stream to a client, right?
| // TODO: should we use logger instead? | ||
| go ReadOutput(cmdStdout, stdout) | ||
| go ReadOutput(cmdStderr, stderr) | ||
| go readOutput(cmdStdout, stdout) |
Collaborator
There was a problem hiding this comment.
For future. Let's do similar to Exec() when it comes to logs. Logger should handle all of that. However, I'm still unsure why io.Multiwriter() in container_manager.go L151. I propose we implement LogStreamer and use it as drop in replacement for this. WDYT?
Collaborator
Author
There was a problem hiding this comment.
Let's discuss it offline.
artmoskvin
force-pushed
the
artm/runner-test
branch
from
e2455ab to
1143974
Compare
artmoskvin
force-pushed
the
artm/runner-test
branch
from
1143974 to
c5848e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.