Skip to content

Conversation

@artmoskvin
Copy link
Collaborator

@artmoskvin artmoskvin commented Aug 30, 2024

Changelog

  • add devcontainer.ContainerManager responsible for container ops
  • cover it with tests
  • use it in devcontainer.Runner

@artmoskvin artmoskvin marked this pull request as ready for review August 31, 2024 11:05
@artmoskvin artmoskvin requested a review from aleh-null August 31, 2024 11:10
Copy link
Collaborator

@aleh-null aleh-null left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

const DefaultShell = "/bin/sh"
const DefaultWorkingDir = "/workspace"

var DefaultContainerCommand = []string{DefaultShell, "-c", "while sleep 1000; do :; done"}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need a default command?

@artmoskvin artmoskvin merged commit cb75771 into main Sep 1, 2024
@artmoskvin artmoskvin deleted the artm/container-man branch September 1, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants