pkg/project: stop lsp when deleting project #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artmoskvin
force-pushed
the
artm/memory-leak
branch
from
699cbf1 to
42a96a4
Compare
aleh-null
reviewed
Oct 6, 2024
Collaborator
There was a problem hiding this comment.
I don't immediately see how removing the result channel fixes the reported issue where LSP was not terminated. Can you plz explain? What I think might have happened is that we hit error prior to that and returned not even attempting to shut it down, or the shutdown was not successful. For this reason I think we should go with multi errors, maybe also add a retry mechanism.
aleh-null
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.