Issue 116 #119
Merged
Issue 116 #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artmoskvin
reviewed
Sep 28, 2024
artmoskvin
force-pushed
the
issue-116
branch
from
343b2cd to
27eedcd
Compare
artmoskvin
reviewed
Sep 28, 2024
| } | ||
| } | ||
|
|
||
| func TestToJSON2(t *testing.T) { |
Collaborator
Author
There was a problem hiding this comment.
Probably a good idea to have test on the actual dev container. WDYT of using https://github.com/marcozac/go-jsonc in the future?
aleh-null
commented
Sep 28, 2024
Collaborator
Author
aleh-null
left a comment
aleh-null
left a comment
There was a problem hiding this comment.
Just a rename suggesting. Otherwise LGTM.
pkg/devcontainer/image_manager.go
Outdated
|
|
||
| // CheckLocalImage checks if an image with the given name exists locally. | ||
| // It returns true if the image exists, false if it doesn't, and an error if the check fails. | ||
| func (im *DockerImageManager) CheckLocalImage(ctx context.Context, name string) (bool, error) { |
Collaborator
Author
There was a problem hiding this comment.
rename CheckLocalImage() -> LocalImageExists()
aleh-null
commented
Sep 28, 2024
pkg/devcontainer/runner.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func (r *DockerRunner) pullOrBuildImage(ctx context.Context, config Config, projectPath string) (string, error) { |
Collaborator
Author
There was a problem hiding this comment.
Hm, we do more that that. Maybe we should just abstract case config.IsImageDevContainer()
Collaborator
There was a problem hiding this comment.
extracted the IsImageDevContainer case in a separate method. we can abstract the whole image thing further into something like ImageProvider but i think it's an overkill for now.
artmoskvin
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.