StatelessSession insertAll in batch does not do batching

[s4iko]

I tried the method insertAll(int batchSize, Object... entities) but it does not do batching to insert the entities, they are all inserted using a separated query.
I didn't find any documentation about insertAll.
Do I need to add some configuration to enable batching with StatelessSession ?
Do the dialect limit the use of the StatelessSession (mine is PostgreSQLDialect included in Hibernate core 6.6.6) ?

Thanks for your help :)

Quarkus: 3.18.2
Hibernate reactive: 2.4.4

[gavinking]

but it does not do batching to insert the entities, they are all inserted using a separated query.

How did you make this determination?

Impossible to help you when you have not attached any sort of reproducer.

[DavideD]

I've created a quick test and it actually seems something is not right: DavideD@d6a35be

[gavinking]

But are you sure that the number of logged statements tells you anything about whether those statements are being batched or not?

I don't recall how it worked in reactive, but that's certainly not how it works in ORM.

[DavideD]

The vert.x SQL client expects a query and a list of parameters, we log before calling the client, so checking the log should work for testing. The batch execution happens here:

hibernate-reactive/hibernate-reactive-core/src/main/java/org/hibernate/reactive/pool/impl/SqlClientConnection.java

Line 258 in e1aff8f

return client().preparedQuery( sql ).executeBatch( parameters ).toCompletionStage()

I can also see that it works for the regular session, and that the batch options is skipped for some reason using the debugger.

[gavinking]

OK, fine.

[gavinking]

OK, @DavideD I believe I found the bug and have a fix.

[gavinking]

OK, @DavideD I believe I found the bug and have a fix.

Or maybe not. Haha.

[DavideD]

Or maybe not. Haha.

:) It happens to me all the time