Fix flake package #190
Merged
Fix flake package #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related pull request #180 |
gytis-ivaskevicius
approved these changes
Jun 9, 2021
|
I think this looks good, it's not ideal but at least it builds :) |
|
I suppose the only question left then, is if the url should point at master as I currently have it, or to the latest release tag? |
|
I also added an overlay, so users can easily install into a NixOS configuration as well. |
|
Sidenote: There's also a proposal to nixpkgs (NixOS/nixpkgs#126208) by @yusdacra, I wonder why the tests fail there |
archseer
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't ideal for development, since it pulls Helix from GitHub instead of from the underlying filesystem, but it does get the package working for nix users. As an additional convenience, I also embedded the runtime by default.
Opening as a draft as I'm not sure if this is the direction we want to take here, but unless NixOS/nix#3978 get's a proper solution, this may be the best way to do it for now.
Potentially resolves #27