qml: define the settings pages nav elements at page instantiation

This extracts out the navbar element defintions from the settings page
itself, and moves it to where the page is instantiated. This allows the
settings views to be reused anywhere else we want to use them, and are
now no longer limited to being used within the onboarding wizard.

Github-Pull: bitcoin-core#197
Rebased-From: 30db8cc

Author: jarolrod

src/qml/BitcoinApp/SettingsAbout.qml

@@ -10,14 +10,6 @@ import BitcoinApp.Components
 
 InformationPage {
     Layout.fillWidth: true
-    navLeftDetail: NavButton {
-        iconSource: "image://images/caret-left"
-        text: qsTr("Back")
-        onClicked: {
-            introductions.decrementCurrentIndex()
-            swipeView.inSubPage = false
-        }
-    }
     bannerActive: false
     bold: true
     headerText: qsTr("About")

src/qml/BitcoinApp/SettingsConnection.qml

@@ -12,13 +12,6 @@ InformationPage {
     background: null
     Layout.fillWidth: true
     clip: true
-    navRightDetail: NavButton {
-        text: qsTr("Done")
-        onClicked: {
-            connections.decrementCurrentIndex()
-            swipeView.inSubPage = false
-        }
-    }
     bannerActive: false
     bold: true
     headerText: qsTr("Connection settings")

src/qml/BitcoinApp/SettingsDeveloper.qml

@@ -10,14 +10,6 @@ import BitcoinApp.Components
 
 InformationPage {
     Layout.fillWidth: true
-    navLeftDetail: NavButton {
-        iconSource: "image://images/caret-left"
-        text: qsTr("Back")
-        onClicked: {
-            introductions.decrementCurrentIndex()
-            swipeView.inSubPage = true
-        }
-    }
     bannerActive: false
     bold: true
     headerText: qsTr("Developer options")

src/qml/BitcoinApp/SettingsStorage.qml

@@ -10,13 +10,6 @@ import BitcoinApp.Components
 
 InformationPage {
     Layout.fillWidth: true
-    navRightDetail: NavButton {
-        text: qsTr("Done")
-        onClicked: {
-            storages.decrementCurrentIndex()
-            swipeView.inSubPage = false
-        }
-    }
     bannerActive: false
     bold: true
     headerText: qsTr("Storage settings")

src/qml/BitcoinApp/onboarding01.qml

@@ -45,7 +45,25 @@ Page {
             subtext: qsTr("100% open-source & open-design")
             buttonText: qsTr("Start")
         }
-        SettingsAbout {}
-        SettingsDeveloper {}
+        SettingsAbout {
+            navLeftDetail: NavButton {
+                iconSource: "image://images/caret-left"
+                text: qsTr("Back")
+                onClicked: {
+                    introductions.decrementCurrentIndex()
+                    swipeView.inSubPage = false
+                }
+            }
+        }
+        SettingsDeveloper {
+            navLeftDetail: NavButton {
+                iconSource: "image://images/caret-left"
+                text: qsTr("Back")
+                onClicked: {
+                    introductions.decrementCurrentIndex()
+                    swipeView.inSubPage = true
+                }
+            }
+        }
     }
 }

src/qml/BitcoinApp/onboarding05.qml

@@ -51,6 +51,14 @@ Page {
             }
             buttonText: qsTr("Next")
         }
-        SettingsStorage {}
+        SettingsStorage {
+            navRightDetail: NavButton {
+                text: qsTr("Done")
+                onClicked: {
+                    storages.decrementCurrentIndex()
+                    swipeView.inSubPage = false
+                }
+            }
+        }
     }
 }

src/qml/BitcoinApp/onboarding06.qml

@@ -49,6 +49,14 @@ Page {
             lastPage: true
             buttonText: qsTr("Next")
         }
-        SettingsConnection {}
+        SettingsConnection {
+            navRightDetail: NavButton {
+                text: qsTr("Done")
+                onClicked: {
+                    connections.decrementCurrentIndex()
+                    swipeView.inSubPage = false
+                }
+            }
+        }
     }
 }