add 'nextpnr-gowin' tests #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@racerxdl LGTM. Any reason for it to be a draft? |
|
@umarcor well I just wanted to mention in the pull request inside https://github.com/hdl/containers (I'm writing it right now) |
|
Then, if you are good, I'll merge this now. That way, when you push the PR to hdl/containers you can bump the submodule for it to include this change. Otherwise, the container test will fail because this file won't exist! |
|
Sure @umarcor , I tested locally everything and it worked. It correctly checks for the existence of nextpnr_gowin ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added nextpnr-gowin help tests.