Skip to content

Conversation

@frenck
Copy link
Member

@frenck frenck commented Oct 24, 2025

Proposed Changes

Removes support for armv7 systems. This architecture has been deprecated by the Home Assistant project and is pending to be fully dropped next month.

../Frenck

Summary by CodeRabbit

  • Chores
    • Removed support for armhf, armv7, and i386 architectures. The application now supports only aarch64 and amd64 platforms.

@frenck frenck added the breaking-change A breaking change for existing users. label Oct 24, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 24, 2025

Walkthrough

This pull request removes support for armhf, armv7, and i386 architectures across the BookStack project configuration. Changes include removing architecture badges from README documentation, deleting the armv7 entry from the build configuration mapping, and updating the supported architecture list in the config file.

Changes

Cohort / File(s) Summary
Architecture Documentation
README.md
Removed support badges for armhf, armv7, and i386 architectures, including corresponding shield entries and definitions
Build Configuration
bookstack/build.yaml
Removed armv7 entry from build_from mapping; now includes only aarch64 and amd64
Architecture Configuration
bookstack/config.yaml
Removed armv7 from the architecture list

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

Hoppy hop, armv7 must go,
Three architectures in a row,
From configs they fade and depart,
Leaner builds, a lighter heart! 🐰✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "Drop support for armv7 systems" directly and accurately describes the primary change across all modified files in the changeset. The README, build.yaml, and config.yaml files all have modifications related to removing armv7 architecture support, and the title clearly captures this unified purpose. The title is concise, specific, and provides meaningful information that would help a teammate quickly understand the primary objective when scanning the repository history. The PR objectives confirm this is indeed about deprecating armv7 support due to Home Assistant's architectural decisions.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch frenck-2025-0416

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2b34da7 and 3286c73.

📒 Files selected for processing (3)
  • README.md (0 hunks)
  • bookstack/build.yaml (0 hunks)
  • bookstack/config.yaml (0 hunks)
💤 Files with no reviewable changes (3)
  • bookstack/config.yaml
  • bookstack/build.yaml
  • README.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@frenck frenck merged commit f9f70aa into main Oct 24, 2025
19 checks passed
@frenck frenck deleted the frenck-2025-0416 branch October 24, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change A breaking change for existing users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants