Skip to content

Fix Playwright test timeouts on CI by using deterministic load waits #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: deploy-twice-a-day
Choose a base branch
from
Draft

Fix Playwright test timeouts on CI by using deterministic load waits #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
491106b
Initial plan
Copilot Nov 19, 2025
906db87
Fix DOM detachment issues in CI tests
Copilot Nov 19, 2025
c1ce9ba
Comment out action-sshd-cloudflared
hasparus Nov 19, 2025
affcccc
Replace scrollIntoViewIfNeeded with manual scroll and networkidle wait
Copilot Nov 19, 2025
f989e45
Replace networkidle with load wait and remove manual scrolling
Copilot Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,5 +78,5 @@ jobs:
path: playwright-report/
retention-days: 30

- uses: valeriangalliat/action-sshd-cloudflared@v1
if: failure()
# - uses: valeriangalliat/action-sshd-cloudflared@v1
# if: failure()
2 changes: 1 addition & 1 deletion playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export default defineConfig({
screenshot: "only-on-failure",
},

timeout: 60 * 1000,
timeout: 90 * 1000,

projects: [
{
Expand Down
17 changes: 10 additions & 7 deletions test/e2e/community-events.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
import { test, expect, type Locator } from "@playwright/test"

test("Zurich meetup link works", async ({ page }) => {
Expand Down Expand Up @@ -141,7 +141,8 @@
test("event type filters hide cards and lock the last active tag", async ({
page,
}) => {
await page.goto("/community/events")
await page.goto("/community/events", { waitUntil: "load" })

const pastEventsSection = page
.locator("section")
.filter({
Expand All @@ -152,7 +153,8 @@
})
.first()

await pastEventsSection.scrollIntoViewIfNeeded()
await pastEventsSection.waitFor({ state: "visible", timeout: 20000 })
await page.waitForTimeout(1000)

const filterGroup = pastEventsSection.locator("fieldset")

Expand All @@ -164,7 +166,7 @@
name: new RegExp(kind, "i"),
})

if ((await filter.count()) === 0) continue

Check failure on line 169 in test/e2e/community-events.spec.ts

View workflow job for this annotation

GitHub Actions / playwright

[chromium] › test/e2e/community-events.spec.ts:141:1 › event type filters hide cards and lock the last active tag 

  1) [chromium] › test/e2e/community-events.spec.ts:141:1 › event type filters hide cards and lock the last active tag 

    Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
    Error: locator.count: Test timeout of 90000ms exceeded.

      167 |     })
      168 |
    > 169 |     if ((await filter.count()) === 0) continue
          |                       ^
      170 |
      171 |     activeFilters.push({
      172 |       filter,
        at /home/runner/work/graphql.github.io/graphql.github.io/test/e2e/community-events.spec.ts:169:23

Check failure on line 169 in test/e2e/community-events.spec.ts

View workflow job for this annotation

GitHub Actions / playwright

[chromium] › test/e2e/community-events.spec.ts:141:1 › event type filters hide cards and lock the last active tag 

  1) [chromium] › test/e2e/community-events.spec.ts:141:1 › event type filters hide cards and lock the last active tag 

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: locator.count: Test timeout of 90000ms exceeded.

      167 |     })
      168 |
    > 169 |     if ((await filter.count()) === 0) continue
          |                       ^
      170 |
      171 |     activeFilters.push({
      172 |       filter,
        at /home/runner/work/graphql.github.io/graphql.github.io/test/e2e/community-events.spec.ts:169:23

Check failure on line 169 in test/e2e/community-events.spec.ts

View workflow job for this annotation

GitHub Actions / playwright

[chromium] › test/e2e/community-events.spec.ts:141:1 › event type filters hide cards and lock the last active tag 

  1) [chromium] › test/e2e/community-events.spec.ts:141:1 › event type filters hide cards and lock the last active tag 
    Error: locator.count: Test timeout of 90000ms exceeded.

      167 |     })
      168 |
    > 169 |     if ((await filter.count()) === 0) continue
          |                       ^
      170 |
      171 |     activeFilters.push({
      172 |       filter,
        at /home/runner/work/graphql.github.io/graphql.github.io/test/e2e/community-events.spec.ts:169:23

Check failure on line 169 in test/e2e/community-events.spec.ts

View workflow job for this annotation

GitHub Actions / playwright

[chromium] › test/e2e/community-events.spec.ts:141:1 › event type filters hide cards and lock the last active tag 

  1) [chromium] › test/e2e/community-events.spec.ts:141:1 › event type filters hide cards and lock the last active tag 

    Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
    Error: locator.count: Test timeout of 90000ms exceeded.

      167 |     })
      168 |
    > 169 |     if ((await filter.count()) === 0) continue
          |                       ^
      170 |
      171 |     activeFilters.push({
      172 |       filter,
        at /home/runner/work/graphql.github.io/graphql.github.io/test/e2e/community-events.spec.ts:169:23

Check failure on line 169 in test/e2e/community-events.spec.ts

View workflow job for this annotation

GitHub Actions / playwright

[chromium] › test/e2e/community-events.spec.ts:141:1 › event type filters hide cards and lock the last active tag 

  1) [chromium] › test/e2e/community-events.spec.ts:141:1 › event type filters hide cards and lock the last active tag 

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: locator.count: Test timeout of 90000ms exceeded.

      167 |     })
      168 |
    > 169 |     if ((await filter.count()) === 0) continue
          |                       ^
      170 |
      171 |     activeFilters.push({
      172 |       filter,
        at /home/runner/work/graphql.github.io/graphql.github.io/test/e2e/community-events.spec.ts:169:23

Check failure on line 169 in test/e2e/community-events.spec.ts

View workflow job for this annotation

GitHub Actions / playwright

[chromium] › test/e2e/community-events.spec.ts:141:1 › event type filters hide cards and lock the last active tag 

  1) [chromium] › test/e2e/community-events.spec.ts:141:1 › event type filters hide cards and lock the last active tag 
    Error: locator.count: Test timeout of 90000ms exceeded.

      167 |     })
      168 |
    > 169 |     if ((await filter.count()) === 0) continue
          |                       ^
      170 |
      171 |     activeFilters.push({
      172 |       filter,
        at /home/runner/work/graphql.github.io/graphql.github.io/test/e2e/community-events.spec.ts:169:23

activeFilters.push({
filter,
Expand Down Expand Up @@ -216,7 +218,8 @@
test("upcoming and past sections only show events on the correct side of now", async ({
page,
}) => {
await page.goto("/community/events")
await page.goto("/community/events", { waitUntil: "load" })

const upcomingSection = page
.locator("section")
.filter({
Expand All @@ -233,10 +236,10 @@
})
.first()

await Promise.all([
upcomingSection.scrollIntoViewIfNeeded(),
pastEventsSection.scrollIntoViewIfNeeded(),
])
// Wait for both sections to be visible
await upcomingSection.waitFor({ state: "visible", timeout: 20000 })
await pastEventsSection.waitFor({ state: "visible", timeout: 20000 })
await page.waitForTimeout(1000)

const now = Date.now()

Expand All @@ -245,7 +248,7 @@
predicate: (timestamp: number) => boolean,
errorMessage: string,
) => {
const dates = await section.locator("a time").evaluateAll(elements =>

Check failure on line 251 in test/e2e/community-events.spec.ts

View workflow job for this annotation

GitHub Actions / playwright

[chromium] › test/e2e/community-events.spec.ts:218:1 › upcoming and past sections only show events on the correct side of now 

  2) [chromium] › test/e2e/community-events.spec.ts:218:1 › upcoming and past sections only show events on the correct side of now 

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: locator.evaluateAll: Test timeout of 90000ms exceeded.

      249 |     errorMessage: string,
      250 |   ) => {
    > 251 |     const dates = await section.locator("a time").evaluateAll(elements =>
          |                                                   ^
      252 |       elements.map(element => ({
      253 |         iso: element.getAttribute("datetime") ?? "",
      254 |         text: element.textContent?.trim() ?? "",
        at validateSectionDates (/home/runner/work/graphql.github.io/graphql.github.io/test/e2e/community-events.spec.ts:251:51)
        at /home/runner/work/graphql.github.io/graphql.github.io/test/e2e/community-events.spec.ts:277:9

Check failure on line 251 in test/e2e/community-events.spec.ts

View workflow job for this annotation

GitHub Actions / playwright

[chromium] › test/e2e/community-events.spec.ts:218:1 › upcoming and past sections only show events on the correct side of now 

  2) [chromium] › test/e2e/community-events.spec.ts:218:1 › upcoming and past sections only show events on the correct side of now 
    Error: locator.evaluateAll: Test timeout of 90000ms exceeded.

      249 |     errorMessage: string,
      250 |   ) => {
    > 251 |     const dates = await section.locator("a time").evaluateAll(elements =>
          |                                                   ^
      252 |       elements.map(element => ({
      253 |         iso: element.getAttribute("datetime") ?? "",
      254 |         text: element.textContent?.trim() ?? "",
        at validateSectionDates (/home/runner/work/graphql.github.io/graphql.github.io/test/e2e/community-events.spec.ts:251:51)
        at /home/runner/work/graphql.github.io/graphql.github.io/test/e2e/community-events.spec.ts:277:9

Check failure on line 251 in test/e2e/community-events.spec.ts

View workflow job for this annotation

GitHub Actions / playwright

[chromium] › test/e2e/community-events.spec.ts:218:1 › upcoming and past sections only show events on the correct side of now 

  2) [chromium] › test/e2e/community-events.spec.ts:218:1 › upcoming and past sections only show events on the correct side of now 

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: locator.evaluateAll: Test timeout of 90000ms exceeded.

      249 |     errorMessage: string,
      250 |   ) => {
    > 251 |     const dates = await section.locator("a time").evaluateAll(elements =>
          |                                                   ^
      252 |       elements.map(element => ({
      253 |         iso: element.getAttribute("datetime") ?? "",
      254 |         text: element.textContent?.trim() ?? "",
        at validateSectionDates (/home/runner/work/graphql.github.io/graphql.github.io/test/e2e/community-events.spec.ts:251:51)
        at /home/runner/work/graphql.github.io/graphql.github.io/test/e2e/community-events.spec.ts:277:9

Check failure on line 251 in test/e2e/community-events.spec.ts

View workflow job for this annotation

GitHub Actions / playwright

[chromium] › test/e2e/community-events.spec.ts:218:1 › upcoming and past sections only show events on the correct side of now 

  2) [chromium] › test/e2e/community-events.spec.ts:218:1 › upcoming and past sections only show events on the correct side of now 
    Error: locator.evaluateAll: Test timeout of 90000ms exceeded.

      249 |     errorMessage: string,
      250 |   ) => {
    > 251 |     const dates = await section.locator("a time").evaluateAll(elements =>
          |                                                   ^
      252 |       elements.map(element => ({
      253 |         iso: element.getAttribute("datetime") ?? "",
      254 |         text: element.textContent?.trim() ?? "",
        at validateSectionDates (/home/runner/work/graphql.github.io/graphql.github.io/test/e2e/community-events.spec.ts:251:51)
        at /home/runner/work/graphql.github.io/graphql.github.io/test/e2e/community-events.spec.ts:277:9
elements.map(element => ({
iso: element.getAttribute("datetime") ?? "",
text: element.textContent?.trim() ?? "",
Expand Down
Loading