add overwrite method to MonadWriter
#146
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`overwrite` is equivalent to `mapWriter` without output type change. It allows default definitions of all other methods. It has a default definition in terms of `pass` and `listen`.
ghost
Author
|
I just noticed that this repo is completely inactive; closing pull request. |
Collaborator
|
It looks like a non-breaking change, but I think this won't be merged for 2.3.2. I would want others to weigh in on it first. Thanks for the contribution. |
ghost
closed this by deleting the head repository
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overwriteis equivalent tomapWriterwithout output type change. It allows default definitions of all other methods. It has a default definition in terms ofpassandlisten.Normally I would just make
mapWritera method, but unfortunately that would clash with the exports of CPS, Lazy, and Strict. Currently the method order ofoverwriteis sane for the(,)instance but swapped compared tomapWriter. Would it make more sense to keep the API exactly the same?Is the benefit worth the API maintenance cost and learning burden?