Add indentation tests for constructor and deriving #1129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add a star to mark tests as failing, so |
gracjan
changed the title
gracjan
added a commit
that referenced
this pull request
Feb 4, 2016
Add indentation tests for constructor and deriving
|
Great, thanks, that helped a lot. It is already fixed, will be merged when Travis finishes its job. Indentation could use some more test cases. For example we miss test case for LambdaCase: https://coveralls.io/files/1940562436#L580 Can you add it, @karljs? |
|
@gracjan No problem. I will take a look at the other test case you mentioned in the next day or two. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two tests for indenting simple data type definitions. I didn't entirely understand the numbering scheme, so I just made an educated guess and added them at the end. If that's wrong, let me know and I can fix it.
See #1125 for a brief explanation.