-
-
Notifications
You must be signed in to change notification settings - Fork 391
Move Brittany plugin from HIE #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mechanics look good.
The tests need to be updated though, there are some original ones that I brought over that have been commented out.
Also, very important, we need to put a flag around it so it can be disabled by people who do not want to have to depend on AGPL code.
There are plenty of examples out there, e.g. https://hackage.haskell.org/package/ghc-exactprint
Tests need to be refactored and fixed, but they are there already |
Also, ditches stack as our primary test runner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks.
There does not seem to be a CI report for it?
And your summary indicates it is not done yet?
some of the summary can not easily be adressed yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am happy to merge this as use, it is a straight migration of the existing brittany plugin. Best to do one thing only in a PR.
Changes to the API to re-use the existing ParsedSource is a separate task. And is likely to require changes to ghcide to enable generation of API Annotations.
Trivial translation, need to re-use existing parsing result instead of parsing it brittany again.