-
-
Notifications
You must be signed in to change notification settings - Fork 391
Add initial CODEOWNERS file #2619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As discussed in haskell#2588.
Perhaps I should be explicit: please approve this PR or comment approvingly if you're happy with how you appear in it (reactions are a bit ambiguous :) ) |
Sorry for my being absent from HLS these days. I've been rather off-hand from HLS, but I'm still following (hopefully) most of GitHub issues / PRs mostly through e-mail. I will try at least to review new changes to Splice Plugin. Sorry again, and I would like to thank all the contributors who keep HLS alive! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 this will make clear something you have to remember or getting via git blame. Thanks!
This seems like a good idea. There have, in the past, been issues/PRs about I'd also be happy to move it to the Fourmolu GitHub org if we decide to move away from the monorepo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would request a special case for ghcide/session-loader
as I am very familiar with that code and I think my knowledge, prior work and tight integration with hie-bios is very valuable for that very complicated piece of code.
Added a few more:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Co-authored-by: Pepe Iborra <[email protected]>
Co-authored-by: J. S. <[email protected]> Co-authored-by: Junyoung "Clare" Jang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added new brand plugin by @kokobd, 🥇
Co-authored-by: Javier Neira <[email protected]>
To keep this moving, I'm going to remove the people who haven't assented and merge the rest. If they get back to this later then they can just add themselves with a PR! In a while, if we don't have anyone stepping up for the components that don't have anyone listed ( |
I'll happily take on Ormolu if no one else will. |
Due to this comment: #2619 (comment)
Due to this comment: #2619 (comment)
Context: #2588
The goal of this is to ensure that every plugin has at least one person associated with it who takes some responsibility for maintaining it over time.
The meaning of the CODEOWNERS file is: if you are listed on the RHS, you will be tagged for review on any PR touching the files on the LHS. Your review will not be required, so you won't have to look at every trivial change, but ideally you would be able to find time to look at any substantial changes.
The users listed here are entirely my guesses, please do not be offended if you're not in there and you think you should be, or vice versa. I've mostly just picked the original creator of the plugin, which isn't necessarily the right person. Please say if you do not want to be on the list, or if you think there is someone else who would want to be on the list. It's okay if we end up with some plugins that nobody claims responsibility for, at least then we know we have a problem :)
Additionally, my intention is to create a
hls-plugin-maintainers
Github team whose membership is the union of all the people listed here by plugins, so their attention can be drawn to e.g. GHC version compatibility work.Mentioning all the people in this file for comment: @pepeiborra @drsooch @fendor @July541 @Ailrun @alanz @georgefst @jneira @tittoassini @berberman @eddiemundo @rayshih @OliverMadine @konn @isovector @wz1000 @Anton-Latukha @hasufell