WIP: Use Structured Diagnostics for Typed Holes #4695
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgillespie
commented
Aug 20, 2025
| -- plugins/hls-refactor-plugin/test/Main.hs:4011: | ||
| -- CodeAction with title "Replace _toException with E.toException" not found in | ||
| -- [..., "Replace _toException with toException", ...] | ||
| printErr :: SDoc -> T.Text |
There was a problem hiding this comment.
I can't seem to find any combination of SDocContext options that will result in E.toException (that is, with import qualified Control.Exception as E.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds structured diagnostics to the hole fit suggestions. Unfortunately, the suggestions still come through via
ErrorInfo, so we still need to use regex matchers to extract them.