Various PluginError PR suggestions I missed earlier #3737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge fendor/enhance/plugin-logger-structure
Additionally further PluginError constructors and helpers refactoring
michaelpj
approved these changes
Jul 31, 2023
| @@ -80,10 +81,17 @@ prettyResponseError err = errorCode <> ":" <+> errorBody | |||
| errorCode = pretty $ show $ err ^. L.code | |||
| errorBody = pretty $ err ^. L.message | |||
|
|
|||
| pluginNotEnabled :: SMethod m -> [(PluginId, b, a)] -> Text | |||
| pluginNotEnabled :: SMethod m -> [PluginId] -> Text | |||
There was a problem hiding this comment.
should this just be inlined into the function below now?
There was a problem hiding this comment.
Yes, good catch!
| (first (toResponseError . (p,)) <$> runExceptT (f ide a)) `catchAny` -- See Note [Exception handling in plugins] | ||
| (\e -> logAndReturnError' recorder (InR ErrorCodes_InternalError) (ExceptionInPlugin p (Some SMethod_WorkspaceApplyEdit) e)) | ||
| res <- runExceptT (f ide a) `catchAny` -- See Note [Exception handling in plugins] | ||
| (\e -> pure $ Left $ PluginInternalError (exceptionInPlugin p SMethod_WorkspaceExecuteCommand e)) |
There was a problem hiding this comment.
Why this method? And it was different before??
There was a problem hiding this comment.
Because that's it's actually method, see line 171. WorkspaceApplyEdit before was an error, either autocomplete typo, brain fog, or sloppy mistake on my part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.