Skip to content

hls-haddock-comments does not support ghc-exactprint >= 1.0 #2878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 1, 2022
Merged

hls-haddock-comments does not support ghc-exactprint >= 1.0 #2878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e4baef
hls-haddock-comments does not support ghc-exactprint >= 1.0
Bodigrim May 1, 2022
a27813d
Try to make CI happy
Bodigrim May 1, 2022
fbcabd8
Merge branch 'master' into Bodigrim-patch-2
pepeiborra May 1, 2022
5c1dd53
Merge branch 'master' into Bodigrim-patch-2
pepeiborra May 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cabal-ghc92.project
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ allow-newer:
-- https://github.com/lspitzner/butcher/pull/8
butcher:base,

hls-haddock-comments-plugin:ghc-exactprint,

implicit-hie-cradle:bytestring,
implicit-hie-cradle:time,

Expand Down
2 changes: 1 addition & 1 deletion haskell-language-server.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ common callHierarchy
cpp-options: -DcallHierarchy

common haddockComments
if flag(haddockComments)
if flag(haddockComments) && (impl(ghc < 9.2.1) || flag(ignore-plugins-ghc-bounds))
build-depends: hls-haddock-comments-plugin ^>= 1.0
cpp-options: -DhaddockComments

Expand Down
2 changes: 1 addition & 1 deletion plugins/hls-haddock-comments-plugin/hls-haddock-comments-plugin.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ library
, base >=4.12 && <5
, containers
, ghc
, ghc-exactprint
, ghc-exactprint < 1
, ghcide ^>=1.6 || ^>=1.7
, hls-plugin-api ^>=1.3 || ^>=1.4
, lsp-types
Expand Down